The Birdfont Source Code


All Repositories / birdfont.git / commit – RSS feed

Fix warning about missing version list

These changes was commited to the Birdfont repository Sun, 20 Dec 2015 08:28:42 +0000.

Contributing

Send patches or pull requests to johan.mattsson.m@gmail.com.
Clone this repository: git clone https://github.com/johanmattssonm/birdfont.git
author Johan Mattsson <johan.mattsson.m@gmail.com>
Sun, 20 Dec 2015 08:28:42 +0000 (09:28 +0100)
committer Johan Mattsson <johan.mattsson.m@gmail.com>
Sun, 20 Dec 2015 09:35:50 +0000 (10:35 +0100)
commit 109c24ef6ff8b7d692e555dd109e3dd5cc4031fb
tree 3d1e920557c0e5591636320ae72da9220c81d538
parent 1ef9d7150d28f4a1e5946a1245a98095f7068e77
Fix warning about missing version list

libbirdfont/GlyphCanvas.vala
libbirdfont/OverView.vala
libbirdfont/Renderer/FallbackFont.vala
--- a/libbirdfont/GlyphCanvas.vala +++ b/libbirdfont/GlyphCanvas.vala @@ -81,7 +81,7 @@ } public void redraw_area (int x, int y, int w, int h) { - if (MenuTab.has_suppress_event ()) { + if (unlikely (MenuTab.has_suppress_event ())) { warning ("Do not call redraw from background thread."); } else { signal_redraw_area (x, y, w, h);
--- a/libbirdfont/OverView.vala +++ b/libbirdfont/OverView.vala @@ -1311,7 +1311,11 @@ } } - update = !i.version_menu.menu_visible; + if (is_null(i.version_menu)) { + update = false; + } else { + update = !i.version_menu.menu_visible; + } } index++; }
--- a/libbirdfont/Renderer/FallbackFont.vala +++ b/libbirdfont/Renderer/FallbackFont.vala @@ -109,7 +109,6 @@ } public void init_font_config () { - print("init_font_config\n"); FcConfig* config; #if MAC @@ -122,7 +121,7 @@ bool loaded = FcConfigParseAndLoad(config, path, true); if (!loaded) { - warning ("Cannot load fontconfig."); + warning ("Fontconfig initialization failed."); } FcConfigSetCurrent (config); @@ -134,7 +133,7 @@ idle.set_callback (() => { font_config = config; - print("Fontconfog loaded."); + printd("Fontconfig loaded\n"); return false; }); idle.attach (null);